railbird/react-native-video
9
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix lack of onError event

Browse Source 
The native code was receiving the event, but not reasing the event.
Which [apparently](https://github.com/microsoft/react-native-windows/issues/4206) needs to be prefixed with "top" and then that turns into "onError".

Note that this raises the event, but no error object is included. Better than nothing.
This commit is contained in:
Chris Glein 2023-09-18 18:08:21 -07:00
parent 3f48c64364
commit 06593344f6
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
windows/ReactNativeVideoCPP/ReactVideoView.cpp
View File

@ -132,7 +132,13 @@ void ReactVideoView::OnMediaOpened(IInspectable const &, IInspectable const &) {
}); });
} }
void ReactVideoView::OnMediaFailed(IInspectable const &, IInspectable const &) {} void ReactVideoView::OnMediaFailed(IInspectable const &, IInspectable const &) {
runOnQueue([weak_this{get_weak()}]() {
if (auto strong_this{weak_this.get()}) {
strong_this->m_reactContext.DispatchEvent(*strong_this, L"topError", nullptr);
}
});
}
void ReactVideoView::OnMediaEnded(IInspectable const &, IInspectable const &) { void ReactVideoView::OnMediaEnded(IInspectable const &, IInspectable const &) {
runOnQueue([weak_this{get_weak()}]() { runOnQueue([weak_this{get_weak()}]() {