railbird/railbird-gql
10
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Declare taxonomy filter variables on the makes/runs leaderboards #302

Merged
dean merged 1 commits from dean/leaderboard-filter-operations into master 2026-07-21 16:59:35 +00:00
Conversation 0 Commits 1 Files Changed 2 +92 -8
dean commented 2026-07-21 16:31:06 +00:00
Member
Copy Link

The backend leaderboard resolvers gained game_type, table size and pocket
size filters, but GetMakesLeaderboard and GetRunsLeaderboard never declared
them — GraphQL silently drops undeclared variables, so anything the client
passed was ignored and both boards stayed global.

Declare and forward the five filter args on both queries, matching the
names the drill run leaderboard already uses.

The backend leaderboard resolvers gained game_type, table size and pocket size filters, but GetMakesLeaderboard and GetRunsLeaderboard never declared them — GraphQL silently drops undeclared variables, so anything the client passed was ignored and both boards stayed global. Declare and forward the five filter args on both queries, matching the names the drill run leaderboard already uses.
dean added 1 commit 2026-07-21 16:31:07 +00:00
Declare taxonomy filter variables on the makes/runs leaderboards
All checks were successful
Tests / Tests (pull_request) Successful in 18s
Details
aa731b85fc 
The backend leaderboard resolvers gained game_type, table size and pocket
size filters, but GetMakesLeaderboard and GetRunsLeaderboard never declared
them — GraphQL silently drops undeclared variables, so anything the client
passed was ignored and both boards stayed global.

Declare and forward the five filter args on both queries, matching the
names the drill run leaderboard already uses.
dean merged commit 1d73b2d67b into master 2026-07-21 16:59:35 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
alexmalison bcorner colonelpanic countablecloud dean kkathuang loewy micah_weitzman wgester
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: railbird/railbird-gql#302
No description provided.
Delete Branch "dean/leaderboard-filter-operations"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?