railbird/railbird-gql
8
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Added user tags #23

Merged
micah_weitzman merged 2 commits from micah/get-user-tags into master 2024-07-23 23:37:06 -06:00
Conversation 0 Commits 2 Files Changed 2 +19
micah_weitzman commented 2024-07-22 20:44:22 -06:00
Member
Copy Link
No description provided.
micah_weitzman added 1 commit 2024-07-22 20:44:23 -06:00
Added user tags
All checks were successful
Tests / Tests (pull_request) Successful in 7s
Details
b1550b31c5
colonelpanic reviewed 2024-07-22 21:09:51 -06:00
src/index.tsx Outdated
@ -1114,6 +1114,7 @@ export type Query = {
getShotAnnotationTypes: Array<ShotAnnotationTypeGql>;
getShots: Array<ShotGql>;
getUser?: Maybe<UserGql>;
getUserTags: UserTagsGql;
colonelpanic commented 2024-07-22 21:09:51 -06:00
Owner
Copy Link

will this actually be user tags exclusively or also include the default railbird tags?

will this actually be user tags exclusively or also include the default railbird tags?
micah_weitzman commented 2024-07-23 19:36:46 -06:00
Author
Member
Copy Link

I suppose it could be any tag. It might be more useful to have a generic tag.

I suppose it could be any tag. It might be more useful to have a generic tag.
colonelpanic reviewed 2024-07-22 21:14:38 -06:00
src/index.tsx Outdated
@ -1293,6 +1304,11 @@ export type UserPlayTimeGql = {
totalSeconds: Scalars["Float"]["output"];
};
export type UserTagsGql = {
colonelpanic commented 2024-07-22 21:14:38 -06:00
Owner
Copy Link

Do we really need an outer wrapping type?

I suppose if you want to do pagination it could end up being helpful.

Do we really need an outer wrapping type? I suppose if you want to do pagination it could end up being helpful.
micah_weitzman commented 2024-07-23 19:37:53 -06:00
Author
Member
Copy Link

I guess I misinterpreted an error message and thought I had to.

I guess I misinterpreted an error message and thought I had to.
colonelpanic approved these changes 2024-07-22 21:14:46 -06:00
Dismissed
micah_weitzman added 1 commit 2024-07-23 19:53:45 -06:00
Removed wrapper type
All checks were successful
Tests / Tests (pull_request) Successful in 14s
Details
e1237363f0
micah_weitzman dismissed colonelpanic’s review 2024-07-23 19:53:46 -06:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

micah_weitzman requested review from colonelpanic 2024-07-23 19:54:14 -06:00
micah_weitzman removed review request for colonelpanic 2024-07-23 19:54:46 -06:00
micah_weitzman changed title from Added user tags to WIP: Added user tags 2024-07-23 19:54:49 -06:00
micah_weitzman requested review from colonelpanic 2024-07-23 19:55:24 -06:00
micah_weitzman changed title from WIP: Added user tags to Added user tags 2024-07-23 19:55:29 -06:00
colonelpanic approved these changes 2024-07-23 21:32:39 -06:00
micah_weitzman merged commit 4feeba5150 into master 2024-07-23 23:37:06 -06:00
Sign in to join this conversation.
Reviewers
No reviewers
colonelpanic
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: railbird/railbird-gql#23
No description provided.
Delete Branch "micah/get-user-tags"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?