Compare commits

...

9 Commits

Author SHA1 Message Date
f14e117416 Merge pull request 'Add videoId field to playlist in ShotWithAllFeatures fragment' (#210) from loewy/add-video-id-to-playlist-shots-fragment into master
Reviewed-on: #210
2025-11-12 22:16:58 +00:00
3d86c13291 add videoId field to playlist in shot w features fragment
All checks were successful
Tests / Tests (pull_request) Successful in 10s
2025-11-12 14:08:49 -08:00
e63f8600aa Merge pull request 'Add pocket size field to GraphQL schema and operations' (#209) from dean/add-pocket-size-clean into master
Reviewed-on: #209
2025-11-11 21:09:28 +00:00
7e822446da Merge branch 'master' into dean/add-pocket-size-clean
All checks were successful
Tests / Tests (pull_request) Successful in 9s
2025-11-11 20:34:55 +00:00
75ecc5894b Merge pull request 'dean/add-home-feed-option' (#208) from dean/add-home-feed-option into master
Reviewed-on: #208
2025-11-10 22:09:09 +00:00
73c8dd5f57 Merge branch 'master' into dean/add-home-feed-option
All checks were successful
Tests / Tests (pull_request) Successful in 10s
2025-11-10 19:55:16 +00:00
dean
e4223a1a17 Add isFollowedByCurrentUser field and hasFollowing to feed query
All checks were successful
Tests / Tests (pull_request) Successful in 9s
Updated GraphQL operations to support efficient follow status checking:
- Added isFollowedByCurrentUser field to UserSocialsFields fragment
- Removed nested followers array from UserSocialsFields (over-fetching)
- Simplified followUser/unfollowUser mutations to return minimal data
- Added hasFollowing field to GetVideoFeed query for feed mode detection
- Updated getUserFollowingFollowers query to include isFollowedByCurrentUser

These changes enable the mobile app to:
- Display correct follow/unfollow button states without client-side lookups
- Differentiate between "Following" and "Popular" feed modes
- Reduce payload size by removing unnecessary nested data

Backend handles efficient resolution via request-scoped caching.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-09 23:44:39 -08:00
dean
83b7f0d0f6 Add home feed and isFollowedByCurrentUser field
- Add home option to VideoFeedInputGQL for automatic feed selection
- Add hasFollowing field to VideoHistoryGQL response
- Add isFollowedByCurrentUser field to UserGQL to replace followers N+1

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-08 09:15:39 -08:00
dean
a882f98d91 Add home option to VideoFeedInputGQL
The home feed option enables smart feed selection on the backend:
- If user has following: returns FOLLOWING feed
- If user has no following: returns ALL feed
- Always includes hasFollowing flag so frontend knows which feed it got

This allows frontend to make a single query instead of needing to
check following status separately.
2025-11-07 12:16:01 -08:00
6 changed files with 50 additions and 159 deletions

View File

@@ -3178,6 +3178,7 @@ export type UserGql = {
following?: Maybe<Array<UserGql>>; following?: Maybe<Array<UserGql>>;
id: Scalars["Int"]["output"]; id: Scalars["Int"]["output"];
isAdmin?: Maybe<Scalars["Boolean"]["output"]>; isAdmin?: Maybe<Scalars["Boolean"]["output"]>;
isFollowedByCurrentUser?: Maybe<Scalars["Boolean"]["output"]>;
profileImageUri?: Maybe<Scalars["String"]["output"]>; profileImageUri?: Maybe<Scalars["String"]["output"]>;
stripeCustomerId?: Maybe<Scalars["String"]["output"]>; stripeCustomerId?: Maybe<Scalars["String"]["output"]>;
updatedAt?: Maybe<Scalars["DateTime"]["output"]>; updatedAt?: Maybe<Scalars["DateTime"]["output"]>;
@@ -3227,16 +3228,25 @@ export type VideoFeedInputGql =
| { | {
allUsers: Scalars["Boolean"]["input"]; allUsers: Scalars["Boolean"]["input"];
followedByUserId?: never; followedByUserId?: never;
home?: never;
userId?: never; userId?: never;
} }
| { | {
allUsers?: never; allUsers?: never;
followedByUserId: Scalars["Int"]["input"]; followedByUserId: Scalars["Int"]["input"];
home?: never;
userId?: never; userId?: never;
} }
| { | {
allUsers?: never; allUsers?: never;
followedByUserId?: never; followedByUserId?: never;
home: Scalars["Boolean"]["input"];
userId?: never;
}
| {
allUsers?: never;
followedByUserId?: never;
home?: never;
userId: Scalars["Int"]["input"]; userId: Scalars["Int"]["input"];
}; };
@@ -3538,12 +3548,7 @@ export type GetFeedQuery = {
id: number; id: number;
username: string; username: string;
profileImageUri?: string | null; profileImageUri?: string | null;
followers?: Array<{ isFollowedByCurrentUser?: boolean | null;
__typename?: "UserGQL";
id: number;
username: string;
profileImageUri?: string | null;
}> | null;
}; };
}>; }>;
comments: Array<{ comments: Array<{
@@ -3555,12 +3560,7 @@ export type GetFeedQuery = {
id: number; id: number;
username: string; username: string;
profileImageUri?: string | null; profileImageUri?: string | null;
followers?: Array<{ isFollowedByCurrentUser?: boolean | null;
__typename?: "UserGQL";
id: number;
username: string;
profileImageUri?: string | null;
}> | null;
}; };
replies: Array<{ replies: Array<{
__typename?: "CommentGQL"; __typename?: "CommentGQL";
@@ -3571,12 +3571,7 @@ export type GetFeedQuery = {
id: number; id: number;
username: string; username: string;
profileImageUri?: string | null; profileImageUri?: string | null;
followers?: Array<{ isFollowedByCurrentUser?: boolean | null;
__typename?: "UserGQL";
id: number;
username: string;
profileImageUri?: string | null;
}> | null;
}; };
}>; }>;
}>; }>;
@@ -3594,12 +3589,7 @@ export type UserSocialsFieldsFragment = {
id: number; id: number;
username: string; username: string;
profileImageUri?: string | null; profileImageUri?: string | null;
followers?: Array<{ isFollowedByCurrentUser?: boolean | null;
__typename?: "UserGQL";
id: number;
username: string;
profileImageUri?: string | null;
}> | null;
}; };
export type VideoCardFieldsFragment = { export type VideoCardFieldsFragment = {
@@ -3656,12 +3646,7 @@ export type VideoCardFieldsFragment = {
id: number; id: number;
username: string; username: string;
profileImageUri?: string | null; profileImageUri?: string | null;
followers?: Array<{ isFollowedByCurrentUser?: boolean | null;
__typename?: "UserGQL";
id: number;
username: string;
profileImageUri?: string | null;
}> | null;
}; };
}>; }>;
comments: Array<{ comments: Array<{
@@ -3673,12 +3658,7 @@ export type VideoCardFieldsFragment = {
id: number; id: number;
username: string; username: string;
profileImageUri?: string | null; profileImageUri?: string | null;
followers?: Array<{ isFollowedByCurrentUser?: boolean | null;
__typename?: "UserGQL";
id: number;
username: string;
profileImageUri?: string | null;
}> | null;
}; };
replies: Array<{ replies: Array<{
__typename?: "CommentGQL"; __typename?: "CommentGQL";
@@ -3689,12 +3669,7 @@ export type VideoCardFieldsFragment = {
id: number; id: number;
username: string; username: string;
profileImageUri?: string | null; profileImageUri?: string | null;
followers?: Array<{ isFollowedByCurrentUser?: boolean | null;
__typename?: "UserGQL";
id: number;
username: string;
profileImageUri?: string | null;
}> | null;
}; };
}>; }>;
}>; }>;
@@ -3713,6 +3688,7 @@ export type GetVideoFeedQuery = {
__typename?: "Query"; __typename?: "Query";
getFeedVideos: { getFeedVideos: {
__typename?: "VideoHistoryGQL"; __typename?: "VideoHistoryGQL";
hasFollowing: boolean;
videos: Array<{ videos: Array<{
__typename?: "VideoGQL"; __typename?: "VideoGQL";
id: number; id: number;
@@ -3770,12 +3746,7 @@ export type GetVideoFeedQuery = {
id: number; id: number;
username: string; username: string;
profileImageUri?: string | null; profileImageUri?: string | null;
followers?: Array<{ isFollowedByCurrentUser?: boolean | null;
__typename?: "UserGQL";
id: number;
username: string;
profileImageUri?: string | null;
}> | null;
}; };
}>; }>;
comments: Array<{ comments: Array<{
@@ -3787,12 +3758,7 @@ export type GetVideoFeedQuery = {
id: number; id: number;
username: string; username: string;
profileImageUri?: string | null; profileImageUri?: string | null;
followers?: Array<{ isFollowedByCurrentUser?: boolean | null;
__typename?: "UserGQL";
id: number;
username: string;
profileImageUri?: string | null;
}> | null;
}; };
replies: Array<{ replies: Array<{
__typename?: "CommentGQL"; __typename?: "CommentGQL";
@@ -3803,12 +3769,7 @@ export type GetVideoFeedQuery = {
id: number; id: number;
username: string; username: string;
profileImageUri?: string | null; profileImageUri?: string | null;
followers?: Array<{ isFollowedByCurrentUser?: boolean | null;
__typename?: "UserGQL";
id: number;
username: string;
profileImageUri?: string | null;
}> | null;
}; };
}>; }>;
}>; }>;
@@ -4491,6 +4452,7 @@ export type GetShotsWithMetadataFilterResultQuery = {
} | null; } | null;
playlist?: { playlist?: {
__typename?: "HLSPlaylistGQL"; __typename?: "HLSPlaylistGQL";
videoId: number;
segmentDurations: Array<number>; segmentDurations: Array<number>;
} | null; } | null;
} | null; } | null;
@@ -4573,6 +4535,7 @@ export type GetShotsWithMetadataQuery = {
} | null; } | null;
playlist?: { playlist?: {
__typename?: "HLSPlaylistGQL"; __typename?: "HLSPlaylistGQL";
videoId: number;
segmentDurations: Array<number>; segmentDurations: Array<number>;
} | null; } | null;
} | null; } | null;
@@ -4644,6 +4607,7 @@ export type GetShotsByIdsQuery = {
} | null; } | null;
playlist?: { playlist?: {
__typename?: "HLSPlaylistGQL"; __typename?: "HLSPlaylistGQL";
videoId: number;
segmentDurations: Array<number>; segmentDurations: Array<number>;
} | null; } | null;
} | null; } | null;
@@ -4708,6 +4672,7 @@ export type ShotWithAllFeaturesFragment = {
} | null; } | null;
playlist?: { playlist?: {
__typename?: "HLSPlaylistGQL"; __typename?: "HLSPlaylistGQL";
videoId: number;
segmentDurations: Array<number>; segmentDurations: Array<number>;
} | null; } | null;
} | null; } | null;
@@ -4789,6 +4754,7 @@ export type EditShotMutation = {
} | null; } | null;
playlist?: { playlist?: {
__typename?: "HLSPlaylistGQL"; __typename?: "HLSPlaylistGQL";
videoId: number;
segmentDurations: Array<number>; segmentDurations: Array<number>;
} | null; } | null;
} | null; } | null;
@@ -4975,21 +4941,7 @@ export type FollowUserMutationVariables = Exact<{
export type FollowUserMutation = { export type FollowUserMutation = {
__typename?: "Mutation"; __typename?: "Mutation";
followUser: { followUser: { __typename?: "UserGQL"; id: number; username: string };
__typename?: "UserGQL";
username: string;
id: number;
following?: Array<{
__typename?: "UserGQL";
id: number;
username: string;
}> | null;
followers?: Array<{
__typename?: "UserGQL";
id: number;
username: string;
}> | null;
};
}; };
export type UnfollowUserMutationVariables = Exact<{ export type UnfollowUserMutationVariables = Exact<{
@@ -4998,21 +4950,7 @@ export type UnfollowUserMutationVariables = Exact<{
export type UnfollowUserMutation = { export type UnfollowUserMutation = {
__typename?: "Mutation"; __typename?: "Mutation";
unfollowUser: { unfollowUser: { __typename?: "UserGQL"; id: number; username: string };
__typename?: "UserGQL";
username: string;
id: number;
following?: Array<{
__typename?: "UserGQL";
id: number;
username: string;
}> | null;
followers?: Array<{
__typename?: "UserGQL";
id: number;
username: string;
}> | null;
};
}; };
export type GetUserFollowingFollowersQueryVariables = Exact<{ export type GetUserFollowingFollowersQueryVariables = Exact<{
@@ -5029,12 +4967,14 @@ export type GetUserFollowingFollowersQuery = {
id: number; id: number;
username: string; username: string;
profileImageUri?: string | null; profileImageUri?: string | null;
isFollowedByCurrentUser?: boolean | null;
}> | null; }> | null;
followers?: Array<{ followers?: Array<{
__typename?: "UserGQL"; __typename?: "UserGQL";
id: number; id: number;
username: string; username: string;
profileImageUri?: string | null; profileImageUri?: string | null;
isFollowedByCurrentUser?: boolean | null;
}> | null; }> | null;
} | null; } | null;
}; };
@@ -5262,12 +5202,7 @@ export type GetVideoSocialDetailsByIdQuery = {
id: number; id: number;
username: string; username: string;
profileImageUri?: string | null; profileImageUri?: string | null;
followers?: Array<{ isFollowedByCurrentUser?: boolean | null;
__typename?: "UserGQL";
id: number;
username: string;
profileImageUri?: string | null;
}> | null;
}; };
}>; }>;
comments: Array<{ comments: Array<{
@@ -5279,12 +5214,7 @@ export type GetVideoSocialDetailsByIdQuery = {
id: number; id: number;
username: string; username: string;
profileImageUri?: string | null; profileImageUri?: string | null;
followers?: Array<{ isFollowedByCurrentUser?: boolean | null;
__typename?: "UserGQL";
id: number;
username: string;
profileImageUri?: string | null;
}> | null;
}; };
replies: Array<{ replies: Array<{
__typename?: "CommentGQL"; __typename?: "CommentGQL";
@@ -5295,12 +5225,7 @@ export type GetVideoSocialDetailsByIdQuery = {
id: number; id: number;
username: string; username: string;
profileImageUri?: string | null; profileImageUri?: string | null;
followers?: Array<{ isFollowedByCurrentUser?: boolean | null;
__typename?: "UserGQL";
id: number;
username: string;
profileImageUri?: string | null;
}> | null;
}; };
}>; }>;
}>; }>;
@@ -5888,11 +5813,7 @@ export const UserSocialsFieldsFragmentDoc = gql`
id id
username username
profileImageUri profileImageUri
followers { isFollowedByCurrentUser
id
username
profileImageUri
}
} }
`; `;
export const VideoCardFieldsFragmentDoc = gql` export const VideoCardFieldsFragmentDoc = gql`
@@ -6067,6 +5988,7 @@ export const ShotWithAllFeaturesFragmentDoc = gql`
streamSegmentType streamSegmentType
} }
playlist { playlist {
videoId
segmentDurations segmentDurations
} }
} }
@@ -6797,6 +6719,7 @@ export const GetVideoFeedDocument = gql`
hasNextPage hasNextPage
endCursor endCursor
} }
hasFollowing
} }
} }
${VideoCardFieldsFragmentDoc} ${VideoCardFieldsFragmentDoc}
@@ -9571,17 +9494,9 @@ export type GetUserTagsQueryResult = Apollo.QueryResult<
export const FollowUserDocument = gql` export const FollowUserDocument = gql`
mutation followUser($followedUserId: Int!) { mutation followUser($followedUserId: Int!) {
followUser(followedUserId: $followedUserId) { followUser(followedUserId: $followedUserId) {
username
id
following {
id id
username username
} }
followers {
id
username
}
}
} }
`; `;
export type FollowUserMutationFn = Apollo.MutationFunction< export type FollowUserMutationFn = Apollo.MutationFunction<
@@ -9630,17 +9545,9 @@ export type FollowUserMutationOptions = Apollo.BaseMutationOptions<
export const UnfollowUserDocument = gql` export const UnfollowUserDocument = gql`
mutation unfollowUser($followedUserId: Int!) { mutation unfollowUser($followedUserId: Int!) {
unfollowUser(followedUserId: $followedUserId) { unfollowUser(followedUserId: $followedUserId) {
username
id
following {
id id
username username
} }
followers {
id
username
}
}
} }
`; `;
export type UnfollowUserMutationFn = Apollo.MutationFunction< export type UnfollowUserMutationFn = Apollo.MutationFunction<
@@ -9694,11 +9601,13 @@ export const GetUserFollowingFollowersDocument = gql`
id id
username username
profileImageUri profileImageUri
isFollowedByCurrentUser
} }
followers { followers {
id id
username username
profileImageUri profileImageUri
isFollowedByCurrentUser
} }
} }
} }

View File

@@ -19,11 +19,7 @@ fragment UserSocialsFields on UserGQL {
id id
username username
profileImageUri profileImageUri
followers { isFollowedByCurrentUser
id
username
profileImageUri
}
} }
fragment VideoCardFields on VideoGQL { fragment VideoCardFields on VideoGQL {
@@ -116,5 +112,6 @@ query GetVideoFeed(
hasNextPage hasNextPage
endCursor endCursor
} }
hasFollowing
} }
} }

View File

@@ -192,6 +192,7 @@ fragment ShotWithAllFeatures on ShotGQL {
streamSegmentType streamSegmentType
} }
playlist { playlist {
videoId
segmentDurations segmentDurations
} }
} }

View File

@@ -88,32 +88,16 @@ query GetUserTags {
mutation followUser($followedUserId: Int!) { mutation followUser($followedUserId: Int!) {
followUser(followedUserId: $followedUserId) { followUser(followedUserId: $followedUserId) {
username
id
following {
id id
username username
} }
followers {
id
username
}
}
} }
mutation unfollowUser($followedUserId: Int!) { mutation unfollowUser($followedUserId: Int!) {
unfollowUser(followedUserId: $followedUserId) { unfollowUser(followedUserId: $followedUserId) {
username
id
following {
id id
username username
} }
followers {
id
username
}
}
} }
query getUserFollowingFollowers { query getUserFollowingFollowers {
@@ -123,11 +107,13 @@ query getUserFollowingFollowers {
id id
username username
profileImageUri profileImageUri
isFollowedByCurrentUser
} }
followers { followers {
id id
username username
profileImageUri profileImageUri
isFollowedByCurrentUser
} }
} }
} }

View File

@@ -88,11 +88,7 @@ fragment UserSocialsFields on UserGQL {
id id
username username
profileImageUri profileImageUri
followers { isFollowedByCurrentUser
id
username
profileImageUri
}
} }
query GetVideoSocialDetailsById($videoId: Int!) { query GetVideoSocialDetailsById($videoId: Int!) {

View File

@@ -375,6 +375,7 @@ type UserGQL {
agreesToMarketing: Boolean agreesToMarketing: Boolean
following: [UserGQL!] following: [UserGQL!]
followers: [UserGQL!] followers: [UserGQL!]
isFollowedByCurrentUser: Boolean
} }
type ShotGQL { type ShotGQL {
@@ -654,6 +655,7 @@ input VideoFeedInputGQL @oneOf {
followedByUserId: Int followedByUserId: Int
userId: Int userId: Int
allUsers: Boolean allUsers: Boolean
home: Boolean
} }
type MakePercentageIntervalGQL { type MakePercentageIntervalGQL {