colonelpanic/dotfiles
1
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Emacs] Swap eshell-search-path to executable-find

Browse Source
This commit is contained in:
Ivan Malison 2016-10-18 18:25:11 -07:00
parent 45d75def68
commit efd8e14a02
No known key found for this signature in database
GPG Key ID: 62530EFBE99DC2F8
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
dotfiles/emacs.d/README.org
View File

@ -135,15 +135,12 @@ Emacs' built in ~shell-command-to-string~ function has the downside that it
forks a new shell process every time it is executed. This means that any shell forks a new shell process every time it is executed. This means that any shell
startup cost is incurred when this function is called. startup cost is incurred when this function is called.
The following implementation uses eshell's ~eshell-search-path~ to find the The following implementation uses eshell's ~executable-find~ to find the
binary (which is the only reason ~shell-comand-to-string~ is typically used binary (which is the only reason ~shell-comand-to-string~ is typically used
anyway), but it avoids incurring any shell-startup cost. anyway), but it avoids incurring any shell-startup cost.
This was originally inspired by [[https://github.com/bbatsov/projectile/issues/1044][this issue]]. This was originally inspired by [[https://github.com/bbatsov/projectile/issues/1044][this issue]].
#+BEGIN_SRC emacs-lisp #+BEGIN_SRC emacs-lisp
;; We use `eshell-search-path' for this hack
(require 'eshell)
(defun imalison:call-process-to-string (program &rest args) (defun imalison:call-process-to-string (program &rest args)
(with-temp-buffer (with-temp-buffer
(apply 'call-process program nil (current-buffer) nil args) (apply 'call-process program nil (current-buffer) nil args)
@ -152,7 +149,7 @@ This was originally inspired by [[https://github.com/bbatsov/projectile/issues/1
(defun imalison:get-call-process-args-from-shell-command (command) (defun imalison:get-call-process-args-from-shell-command (command)
(cl-destructuring-bind (cl-destructuring-bind
(the-command . args) (split-string command " ") (the-command . args) (split-string command " ")
(let ((binary-path (eshell-search-path the-command))) (let ((binary-path (executable-find the-command)))
(when binary-path (when binary-path
(cons binary-path args))))) (cons binary-path args)))))
@ -770,7 +767,7 @@ A macro for composing functions together to build an interactive command to copy
(defun imalison:edit-script () (defun imalison:edit-script ()
(interactive) (interactive)
(find-file (eshell-search-path (find-file (executable-find
(ido-completing-read "Select a script to edit: " (ido-completing-read "Select a script to edit: "
(imalison:get-executables-on-path))))) (imalison:get-executables-on-path)))))
#+END_SRC #+END_SRC
@ -796,7 +793,7 @@ A macro for composing functions together to build an interactive command to copy
collect item))) collect item)))
(setq kill-ring (nconc kill-ring missing-items)))) (setq kill-ring (nconc kill-ring missing-items))))
(when (eshell-search-path "copyq") (when (executable-find "copyq")
(run-with-idle-timer 10 nil 'imalison:copyq-sync)) (run-with-idle-timer 10 nil 'imalison:copyq-sync))
#+END_SRC #+END_SRC
** Other ** Other
@ -1815,7 +1812,7 @@ I don't use auto-complete at all, so I have set up a hook to automatically disab
*** magithub *** magithub
#+BEGIN_SRC emacs-lisp #+BEGIN_SRC emacs-lisp
(use-package magithub (use-package magithub
:if (eshell-search-path "hub") :if (executable-find "hub")
:after magit :after magit
:disabled t) :disabled t)
#+END_SRC #+END_SRC